anmolbabu has posted comments on this change. Change subject: webadmin : Create + Delete Geo-rep session ......................................................................
Patch Set 43: (5 comments) https://gerrit.ovirt.org/#/c/29691/43/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterVolumeGeoRepCreateModel.java: Line 60: getShowEligibleVolumes().getEntityChangedEvent().addListener(new IEventListener<EventArgs>() { Line 61: @Override Line 62: public void eventRaised(Event<? extends EventArgs> ev, Object sender, EventArgs args) { Line 63: boolean overrideSuggestedConfig = getShowEligibleVolumes().getEntity(); Line 64: if (!overrideSuggestedConfig) { > no need for this local variable. Done Line 65: getVolumesForForceSessionCreate(); Line 66: } else { Line 67: getEligibleVolumes(); Line 68: } Line 169: List<GlusterVolumeEntity> eligibleVolumesList = (List<GlusterVolumeEntity>) vdcReturnValue.getReturnValue(); Line 170: setRecommendationViolations(null); Line 171: setVolumeList(eligibleVolumesList); Line 172: getSlaveClusters().setItems(GlusterVolumeGeoRepCreateModel.this.getClusterForVolumes(eligibleVolumesList)); Line 173: } > These above lines are similar to what is there in getVolumesForForceSession Done Line 174: } Line 175: }); Line 176: Line 177: Frontend.getInstance().runQuery(VdcQueryType.GetGlusterGeoReplicationEligibleVolumes, new IdQueryParameters(masterVolume.getId()), aQuery); Line 215: setStartSession(new EntityModel<Boolean>()); Line 216: setSlaveUserName(new EntityModel<String>()); Line 217: setSlaveUserGroupName(new EntityModel<String>()); Line 218: Line 219: getShowEligibleVolumes().setEntity(false); > Isn't the default is false? Done Line 220: getSlaveUserName().setEntity(constants.rootUser()); Line 221: } Line 222: Line 223: public EntityModel<String> getSlaveUserName() { https://gerrit.ovirt.org/#/c/29691/43/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 224: @Override Line 225: public void executeCommand(UICommand command) { Line 226: super.executeCommand(command); Line 227: if (command.equals(getNewSessionCommand())) { Line 228: createNewGeoRepSession(); > createGeoRepSession() Done Line 229: } else if (command.equals(getRemoveSessionCommand())) { Line 230: removeGeoRepSession(); Line 231: } else if(command.equals(getStartSessionCommand())) { Line 232: startGeoRepSession(); https://gerrit.ovirt.org/#/c/29691/43/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupView.java: Line 175: public void edit(final GlusterVolumeGeoRepCreateModel object) { Line 176: driver.edit(object); Line 177: setSuggestedConfigViolations(object.getRecommendationViolations()); Line 178: Line 179: setUserGroupVisibility(false); > This is should go to setVisibilities() function Done Line 180: } Line 181: Line 182: @Override Line 183: public void setFailureMessage(String failureMessage) { -- To view, visit https://gerrit.ovirt.org/29691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied7317d456bf66db9a7800ba7106f2e8ec66429c Gerrit-PatchSet: 43 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
