Allon Mureinik has posted comments on this change. Change subject: core: Replaced getDiskImageDAO with getDiskImageDao ......................................................................
Patch Set 4: I would prefer that you didn't submit this (1 inline comment) See inline comment - this is the cause for the NPE Yair is referring. Other than that - looks great. .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java Line 212 Line 213 Line 214 Line 215 Line 216 This method should not be removed - it's an explicit overriding so that the mock object can be returned. -- To view, visit http://gerrit.ovirt.org/7846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib82d0c80652c8c4a10019ce515051eb1e60dfa92 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
