Eli Mesika has posted comments on this change. Change subject: gluster: Alert if volume snapshot max soft limit reached ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39231/1/packaging/dbscripts/audit_log_sp.sql File packaging/dbscripts/audit_log_sp.sql: Line 310: AS $procedure$ Line 311: BEGIN Line 312: RETURN QUERY SELECT * Line 313: FROM audit_log Line 314: WHERE gluster_volume_id = v_gluster_volume_id and log_type = v_log_type; audit_log is a big table I think it worth to add a index on that, otherwise we might have table scans here Line 315: END; $procedure$ -- To view, visit https://gerrit.ovirt.org/39231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96ad64aa30a674bdc2c72e617fc71e13854fab85 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
