Shubhendu Tripathi has uploaded a new change for review.

Change subject: webadmin: Disabled selection of rows
......................................................................

webadmin: Disabled selection of rows

Earlier the gluster volume sanpshot config listing table
supported selection of rows, and it used to cause issues
as the editable column values used to become invisible.
Disabled the row selection for the table so that user
can only change the values in the text boxes.

Change-Id: I27ab7ee81745d468d0423294cc06b9183406c103
Signed-off-by: Shubhendu Tripathi <shtri...@redhat.com>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterClusterSnapshotConfigureOptionsPopupView.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotConfigureOptionsPopupView.java
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/35/39235/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterClusterSnapshotConfigureOptionsPopupView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterClusterSnapshotConfigureOptionsPopupView.java
index 224fa28..eb0a0b4 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterClusterSnapshotConfigureOptionsPopupView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterClusterSnapshotConfigureOptionsPopupView.java
@@ -26,6 +26,7 @@
 import com.google.gwt.uibinder.client.UiField;
 import com.google.gwt.user.cellview.client.Column;
 import com.google.gwt.user.client.ui.Label;
+import com.google.gwt.view.client.NoSelectionModel;
 import com.google.inject.Inject;
 
 public class GlusterClusterSnapshotConfigureOptionsPopupView extends 
AbstractModelBoundPopupView<GlusterClusterSnapshotConfigModel> implements 
GlusterClusterSnapshotConfigureOptionsPopupPresenterWidget.ViewDef {
@@ -73,6 +74,7 @@
         clusterEditor = new ListModelListBoxEditor<>(new 
NameRenderer<VDSGroup>());
 
         configsTable = new EntityModelCellTable<>(false, true);
+        configsTable.setSelectionModel(new NoSelectionModel());
 
         configsTable.addColumn(new 
AbstractEntityModelTextColumn<GlusterVolumeSnapshotConfig>() {
             @Override
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotConfigureOptionsPopupView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotConfigureOptionsPopupView.java
index c53ea81..a160471 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotConfigureOptionsPopupView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeSnapshotConfigureOptionsPopupView.java
@@ -24,6 +24,7 @@
 import com.google.gwt.uibinder.client.UiField;
 import com.google.gwt.user.cellview.client.Column;
 import com.google.gwt.user.client.ui.Label;
+import com.google.gwt.view.client.NoSelectionModel;
 import com.google.inject.Inject;
 
 public class GlusterVolumeSnapshotConfigureOptionsPopupView extends 
AbstractModelBoundPopupView<GlusterVolumeSnapshotConfigModel> implements 
GlusterVolumeSnapshotConfigureOptionsPopupPresenterWidget.ViewDef {
@@ -75,6 +76,7 @@
     private void initEditors() {
         configsTable =
                 new 
EntityModelCellTable<ListModel<EntityModel<VolumeSnapshotOptionModel>>>(false, 
true);
+        configsTable.setSelectionModel(new NoSelectionModel());
 
         configsTable.addColumn(new 
AbstractEntityModelTextColumn<VolumeSnapshotOptionModel>() {
             @Override


-- 
To view, visit https://gerrit.ovirt.org/39235
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27ab7ee81745d468d0423294cc06b9183406c103
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to