Sharad Mishra has uploaded a new change for review.
Change subject: engine: Remove unnecessary code and add check for NPE.
......................................................................
engine: Remove unnecessary code and add check for NPE.
I don't understand why we add lists.get(0). Then add all entries.
The for loop is called even in case where lists is null.
Change-Id: Id771f4bd5342dc90a03ee1bd6a52dc285fb85765
Signed-off-by: Sharad Mishra <snmis...@linux.vnet.ibm.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
1 file changed, 4 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/7916/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
index 69e0234..5506169 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
@@ -922,12 +922,10 @@
{
ArrayList<T> result = new ArrayList<T>();
- if (lists != null && !lists.isEmpty()) {
- result.addAll(lists.get(0));
- }
-
- for (ArrayList<T> list : lists) {
- result.retainAll(list);
+ if (lists != null) {
+ for (ArrayList<T> list : lists) {
+ result.retainAll(list);
+ }
}
return result;
--
To view, visit http://gerrit.ovirt.org/7916
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id771f4bd5342dc90a03ee1bd6a52dc285fb85765
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
