Ravi Nori has posted comments on this change. Change subject: aaa: Rework webadmin login sequence ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/38212/5/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManager.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManager.java: Line 33: Line 34: /** Line 35: * Flag that tells us if we are logged in or not. Line 36: */ Line 37: private boolean loggedIn = true; > what does it mean? why do we need this? how come we are not logged in? :) In the original webadmin/userportal this flag is set when the login sequence is successfully completed. In the new sequence once the user has access to webadmin/userportal he is considered as logged in. So this flag needs to be true or completely removed Line 38: Line 39: /** Line 40: * Constructor. Line 41: * @param operationProcessor the operation processor. https://gerrit.ovirt.org/#/c/38212/5/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java: Line 211: HttpSession session = request.getSession(); Line 212: Object value = session.getAttribute(UI_PREFIX + key); Line 213: if (value == null) { Line 214: value = session.getAttribute(key); Line 215: } > hmm... this is also not directly related to aaa, right? can be pushed regar Not related to aaa Line 216: String result = null; Line 217: if (value instanceof String) { Line 218: result = (String)value; Line 219: } else if (value != null) { -- To view, visit https://gerrit.ovirt.org/38212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76ecd389f4938e294d1b3d82f5e1a42eb60d9a20 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
