Maor Lipchuk has uploaded a new change for review. Change subject: core: Validate attach Cinder only if DC was chosen ......................................................................
core: Validate attach Cinder only if DC was chosen Validate attach Cinder to Data Center only if Data Center was chosen when adding a new provider Change-Id: I9b06b8884c06db9912047290c875782b1a942fb1 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipc...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/CinderProviderValidator.java 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/39177/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/CinderProviderValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/CinderProviderValidator.java index 3a219c0..05c4b42 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/CinderProviderValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/CinderProviderValidator.java @@ -20,7 +20,10 @@ } public ValidationResult validateAddProvider() { - return validateAttachStorageDomain(); + if (getStoragePool() != null) { + return validateAttachStorageDomain(); + } + return ValidationResult.VALID; } private ValidationResult validateAttachStorageDomain() { -- To view, visit https://gerrit.ovirt.org/39177 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9b06b8884c06db9912047290c875782b1a942fb1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches