Maor Lipchuk has uploaded a new change for review. Change subject: webadmin: Add support to attach Storage to Data Center ......................................................................
webadmin: Add support to attach Storage to Data Center Adding support for attaching Storage Domain to Data Center from the Storage main tab Change-Id: Ifa621603e44b1c625448728f03cb5b4f1d5125be Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Maor Lipchuk <mlipc...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/79/39179/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java index a7c8bc2..4361301 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java @@ -19,6 +19,7 @@ import org.ovirt.engine.core.common.businessentities.StoragePoolStatus; import org.ovirt.engine.core.common.businessentities.VDS; import org.ovirt.engine.core.common.businessentities.storage.StorageType; +import org.ovirt.engine.core.common.queries.ConfigurationValues; import org.ovirt.engine.core.common.queries.IdQueryParameters; import org.ovirt.engine.core.common.queries.VdcQueryReturnValue; import org.ovirt.engine.core.common.queries.VdcQueryType; @@ -245,14 +246,21 @@ StorageDataCenterListModel listModel = (StorageDataCenterListModel) target; listModel.setavailableDatacenters((ArrayList<StoragePool>) returnValue); + boolean addDatacenter = false; for (StoragePool dataCenter : listModel.getavailableDatacenters()) { switch (getEntity().getStorageDomainType()) { case Master: case Data: - boolean addDatacenter = + addDatacenter = (dataCenter.getStatus() == StoragePoolStatus.Uninitialized || dataCenter.getStatus() == StoragePoolStatus.Up) && (dataCenter.getStoragePoolFormatType() == null || dataCenter.getStoragePoolFormatType() == getEntity().getStorageStaticData() .getStorageFormat() && dataCenter.isLocal() == (getEntity().getStorageType() == StorageType.LOCALFS)); + addToAttachCandidateDatacenters(dataCenter, addDatacenter); + break; + case Volume: + boolean isCinderSupported = (Boolean) AsyncDataProvider.getInstance().getConfigValuePreConverted( + ConfigurationValues.CinderProviderSupported, dataCenter.getCompatibilityVersion().toString()); + addDatacenter = isCinderSupported && dataCenter.getStatus() == StoragePoolStatus.Up; addToAttachCandidateDatacenters(dataCenter, addDatacenter); break; case ISO: @@ -534,6 +542,11 @@ return localStorages.substring(0, localStorages.length() - 2); } + @Override + protected void itemsChanged() { + super.itemsChanged(); + } + private boolean containsLocalStorage(ConfirmationModel model) { for (StorageDomain a : Linq.<StorageDomain> cast(getSelectedItems())) -- To view, visit https://gerrit.ovirt.org/39179 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifa621603e44b1c625448728f03cb5b4f1d5125be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
