Tal Nisan has submitted this change and it was merged. Change subject: core: Switched ineritance between Connect & Disconnet pool params (#846768) ......................................................................
core: Switched ineritance between Connect & Disconnet pool params (#846768) https://bugzilla.redhat.com/846768 Switched inheritance between connect storage pool VDS command params and disconnect storage pool VDS command params, disconnect was inheriting from connect which had more parameters than needed to disconnect which had to be filled with static values and appear in the log misleading, now connect inherits from disconnect thus no redundant parameters are used Change-Id: I01f0b389508b7b9b30169ba9a1fdfa2effc8d74e Signed-off-by: Tal Nisan <tni...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStoragePoolVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DisconnectStoragePoolVDSCommandParameters.java 2 files changed, 36 insertions(+), 28 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01f0b389508b7b9b30169ba9a1fdfa2effc8d74e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
