Martin Peřina has posted comments on this change. Change subject: core: adding event when host is reconnecting. ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/36405/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 750: } Line 751: Line 752: private void logChangeStatusToConnecting(long timeoutToFence) { Line 753: AuditLogableBase auditLogableBase = new AuditLogableBase(cachedVds.getId()); Line 754: AuditLogDirector.log(auditLogableBase, AuditLogType.VDS_HOST_RECONNECTING); Same comment as in previous patchset: Why do we add another audit log message when we already have VDS_HOST_NOT_RESPONDING_CONNECTING message in place? Wouldn't it be better just to rephrase the existing message as IMO it's very hard to understand for user while the new suggested message is very clear. Line 755: Line 756: log.warn("Host '{}' is not responding. It will stay in Connecting state for a grace period " + Line 757: "of {} seconds and after that an attempt to fence the host will be issued.", Line 758: cachedVds.getName(), -- To view, visit https://gerrit.ovirt.org/36405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68a9b16564d1bd8f0bb09e1b8bf6afe02baae424 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
