Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: generate cloud-init ISO image ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/38811/8/src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py File src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py: Line 105: ohostedcons.VMEnv.CLOUD_INIT_ROOTPWD Line 106: ] or Line 107: self.environment[ Line 108: ohostedcons.VMEnv.CLOUD_INIT_INSTANCEHNAME Line 109: ] > 'is not None' below should be above? Perhaps even: interactive = set( [ self.environment[ohostedcons.VMEnv.GENERATE_CLOUD_INIT_ISO] self.environment[ohostedcons.VMEnv.CLOUD_INIT_ROOTPWD] self.environment[ohostedcons.VMEnv.CLOUD_INIT_INSTANCEHNAME] ] ) == set([None]) Or is this going too far :-) Line 110: ) is not None: Line 111: interactive = False Line 112: Line 113: if interactive: -- To view, visit https://gerrit.ovirt.org/38811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec4f409203e3a2d6da314208e9a0f422be00ce1b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
