Moti Asayag has posted comments on this change. Change subject: core: Support transactions for Quartz jobs ......................................................................
Patch Set 28: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/36370/28/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/JobWrapper.java File backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/JobWrapper.java: Line 47: final Method methodToRun; Line 48: if (!cachedMethods.containsKey(methodKey)) { Line 49: cachedMethods.putIfAbsent(methodKey, getMethodToRun(instance, methodName)); Line 50: } Line 51: methodToRun = cachedMethods.get(methodKey); on the left side there used to be check for the existence of the method: if (methodToRun == null) {...} if the method doesn't exists - it is purely code error, and should be raised IMO even on engine startup time / enforced by unit test if feasible. but i won't block this patch on this. Line 52: invokeMethod(instance, methodToRun, methodParams); Line 53: } catch (Exception e) { Line 54: log.error("Failed to invoke scheduled method {}: {}", methodName, e.getMessage()); Line 55: log.debug("Exception", e); -- To view, visit https://gerrit.ovirt.org/36370 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7eb67e6aeef9080b5647cb84b1cf701c720ce29d Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
