Moti Asayag has posted comments on this change. Change subject: engine: create/update host_nic_vfsConfig according to HostDevListByCaps ......................................................................
Patch Set 9: Code-Review+2 (1 comment) please extract the persistence logic into a class. https://gerrit.ovirt.org/#/c/37386/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java: Line 101: Line 102: setSucceeded(true); Line 103: } Line 104: Line 105: private void handleHostNicVfsConfigUpdate(final Map<String, HostDevice> oldMap, please extract the logic of this method into a class. Line 106: final List<HostDevice> newDevices, Line 107: final List<HostDevice> changedDevices, Line 108: final List<HostDevice> removedDevices) { Line 109: final List<HostNicVfsConfig> newHostNicVfsConfigs = new ArrayList<>(); -- To view, visit https://gerrit.ovirt.org/37386 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60ab755a75d93d4bafa5be984b267104f4636197 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
