Martin Peřina has posted comments on this change. Change subject: core: Prepare FenceVdsVDSCommand params on caller ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/38232/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java: Line 247: agent.getType(), Line 248: agent.getOptions() == null ? "" : agent.getOptions(), Line 249: architectureType), Line 250: proxyHost.getVdsGroupCompatibilityVersion().toString() Line 251: ).ToInternalString(); > ToInternalString is not Java convention :) Yeah, I plan to clean remaining fencing classes like VdsFenceOptions in later patches, I already have a note for this :-) Line 252: return managementOptions; Line 253: } Line 254: Line 255: /** Line 318: } Line 319: return map; Line 320: } Line 321: Line 322: protected Map<Guid, Integer> createStorageDomainHostIdMap() { > Strange, I have some deja vu of this method, are you sure you did not creat This method was just move here from FenceVdsVDCCommand as a part of cleanup Line 323: Map<Guid, Integer> map = null; Line 324: if (fencingPolicy.isSkipFencingIfSDActive()) { Line 325: map = new HashMap<>(); Line 326: -- To view, visit https://gerrit.ovirt.org/38232 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie17020705e411160f0cceb149d1fe64185d612a5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
