Martin Peřina has posted comments on this change. Change subject: core: FenceVdsVDSCommandParameters code cleanup ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/38061/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java: Line 187: .RunVdsCommand( Line 188: VDSCommandType.FenceVds, Line 189: new FenceVdsVDSCommandParameters( Line 190: proxyHost.getId(), Line 191: _vds.getId(), > once again, if we are at re factoring, please remove _ Whole FenceExecutor class will be removed in last patch, this is only preparation so newly introduced classes won't have "ugly" code :-) Line 192: realAgent, Line 193: action, Line 194: fencingPolicy)); Line 195: } -- To view, visit https://gerrit.ovirt.org/38061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I055276a4012180fda23bb2063c38df3bdd6ce876 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
