Martin Peřina has posted comments on this change. Change subject: core: Provide meaningful FenceAgent.toString() ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38121/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceAgent.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceAgent.java: Line 195: Line 196: @Override Line 197: public String toString() { Line 198: StringBuilder sb = new StringBuilder(getClass().getName()); Line 199: sb.append("={id='"); > FYI, consider a ToStringBuilder of apache lang commons. Well, personally I used those toString() like since ages, because of debug logging. I know there are libraries (like ToStringBuilder in commons-lang or MoreObjects.ToStringHelper in guava) that can save a bit code, but currenlty we compile our business entities with GWT so those libraries cannot be used :-( Line 200: sb.append(getId()); Line 201: sb.append("', hostId='"); Line 202: sb.append(getHostId()); Line 203: sb.append("', order='"); -- To view, visit https://gerrit.ovirt.org/38121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e83e80f7a1701a42aa06a64501a30b4aa94c244 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
