Alona Kaplan has posted comments on this change. Change subject: engine: introduce HostNicVfsConfigHelper ......................................................................
Patch Set 7: (4 comments) https://gerrit.ovirt.org/#/c/37720/7/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostNicVfsConfigHelperImplTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostNicVfsConfigHelperImplTest.java: Line 130: } Line 131: Line 132: @Test Line 133: public void isNetworkDevicePossitive() { Line 134: assertEquals(false, hostNicVfsConfigHelper.isNetworkDevice(pciDevice)); > assertFalse Done Line 135: } Line 136: Line 137: @Test Line 138: public void isNetworkDeviceNegtive() { Line 135: } Line 136: Line 137: @Test Line 138: public void isNetworkDeviceNegtive() { Line 139: assertEquals(true, hostNicVfsConfigHelper.isNetworkDevice(netDevice)); > assertTrue Done Line 140: } Line 141: Line 142: @Test Line 143: public void updateHostNicVfsConfigWithNumVfsData() { Line 308: commonIsSriovDevice(false); Line 309: try { Line 310: hostNicVfsConfigHelper.getFreeVf(nic); Line 311: } catch (Exception exception) { Line 312: assertTrue(exception instanceof UnsupportedOperationException); > if you expect an exception in this flow, you should use the Done Line 313: } Line 314: } Line 315: Line 316: @Test Line 388: Line 389: Collection<HostDevice> capturedDevices = hostDevicesCaptor.getValue(); Line 390: Line 391: assertEquals(1, capturedDevices.size()); Line 392: assertEquals(vf, capturedDevices.iterator().next()); > please replace with: Done- assertThat(capturedDevices, hasItem(vf)); Line 393: } -- To view, visit https://gerrit.ovirt.org/37720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588d619a296cb894f86cce6491337351206e21c2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
