Moti Asayag has posted comments on this change. Change subject: engine: Replace CacheWrapper with plan Map ......................................................................
Patch Set 2: > The motivation here is clear, however - do we really want to use a > plain map and not something with eviction policy? I don't think it is required, since we don't expect that sort of cache to grow beyond capability to hold. Once command is ended, the entry is manually removed. Applying some auto-eviction policy might result in unexpected behavior, since by the current implementation the maps are being updated from the db only once at the beginning. -- To view, visit https://gerrit.ovirt.org/38698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fc00faa1e71a43b544cadd8f825c06799ec1154 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
