Kanagaraj M has posted comments on this change. Change subject: webadmin : Create + Delete Geo-rep session ......................................................................
Patch Set 39: (3 comments) https://gerrit.ovirt.org/#/c/29691/39/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java: Line 228: createNewGeoRepSession createGeoRepSession https://gerrit.ovirt.org/#/c/29691/39/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/GlusterVolumeGeoRepCreateSessionPopupView.java: Line 188: object.getShowEligibleVolumes().getEntityChangedEvent() This should be done in the model Line 228: object.getSlaveHosts().setItems(hostsInCurrentVolume); Line 229: } Line 230: }; Line 231: object.getSlaveVolumes().getSelectedItemChangedEvent().addListener(slaveVolumeEventListener); Line 232: Pls move the above code to model Line 233: } Line 234: Line 235: @Override Line 236: public void setFailureMessage(String failureMessage) { -- To view, visit https://gerrit.ovirt.org/29691 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied7317d456bf66db9a7800ba7106f2e8ec66429c Gerrit-PatchSet: 39 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
