Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Progress indicator during login
......................................................................
webadmin,userportal: Progress indicator during login
This patch makes sure that a progress indicator, represented
as the 'wait' mouse cursor, is shown during the entire login
process.
>From UiCommon/GWTP point of view, the login process consists
of following steps:
0. Default place of login section (#login) gets revealed
1a. If the user is already logged-in on the backend:
* UiCommon LoginModel is instructed to sign the user
in automatically by calling its AutoLogin method
* AutoLogin method takes care of populating appropriate
UI fields (UserName, Domain) and fires LoggedInEvent
1b. If the user is NOT already logged-in on the backend:
* User fills the login form and hits Enter/Login
* UiCommon LoginModel is instructed to initiate the login
operation (authentication) by calling its Login method
* If successful, Login method fires LoggedInEvent
2. WebAdmin/UserPortal ApplicationInit.onLogin method gets
called in response to LoginModel's LoggedInEvent:
* Both WebAdmin and UserPortal do some early init logic
and then call BaseApplicationInit.performLogin method
* BaseApplicationInit.performLogin represents actions
taken by UI after successful user authentication
3. Default place of main section (#vms) gets revealed
Instead of showing/hiding progress indicator for each of the
steps outlined above (e.g. using LoginModel "Progress" for
the authentication operation in step 1b), progress indicator
is shown once, when the actual login process starts (1a/1b),
and is hidden after reaching main section (3).
LockInteractionManager is the class responsible for handling
progress indicator. For now, it only reacts to "GWTP place
transition finished" events, in order to hide the progress
indicator after GWTP place transition (e.g. #login -> #vms).
In future, it can react to "GWTP place transition started"
events as well.
For now, there is only one kind of progress indicator:
'wait' mouse cursor (applicable to login section). In future,
there might be another kind of progress indicator applicable
for main section.
Change-Id: Iecc4892e0848bfedf63a974b94acf2564241a0c7
Signed-off-by: Vojtech Szocs <vsz...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java
A
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/LockInteractionManager.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DeferredModelCommandInvoker.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/presenter/LoginPopupPresenterWidget.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/system/ApplicationInit.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/presenter/LoginPopupPresenterWidget.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
10 files changed, 139 insertions(+), 43 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecc4892e0848bfedf63a974b94acf2564241a0c7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
