Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: raising on invalid application mode values ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39094/1//COMMIT_MSG Commit Message: Line 6: Line 7: packaging: setup: raising on invalid application mode values Line 8: Line 9: It was threating every invalid application mode values as Line 10: virtOnly. Checking it for a more consistent behaviour. Please add notes about setting application mode to 255, should be documented. Line 11: Line 12: Change-Id: Ic47e171ddc76a9881e4a915f62dbae762a72f9f8 Line 13: Bug-Url: https://bugzilla.redhat.com/1149575 -- To view, visit https://gerrit.ovirt.org/39094 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47e171ddc76a9881e4a915f62dbae762a72f9f8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches