Tomas Jelinek has posted comments on this change. Change subject: frontend: Add infrastructure for Console Foreign Menu ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/38986/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEngineCertificateQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEngineCertificateQuery.java: Line 3: import org.ovirt.engine.core.common.queries.VdcQueryParametersBase; Line 4: import org.ovirt.engine.core.utils.PKIResources; Line 5: Line 6: public class GetEngineCertificateQuery<P extends VdcQueryParametersBase> extends QueriesCommandBase<P> { Line 7: public GetEngineCertificateQuery(P parameters) { this seems to be unused Line 8: super(parameters); Line 9: } Line 10: Line 11: @Override https://gerrit.ovirt.org/#/c/38986/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java: Line 129: GetNumberOfVmsInVdsGroupByVdsGroupId, Line 130: Line 131: // Certificate Line 132: GetCACertificate(VdcQueryAuthType.User), Line 133: GetEngineCertificate(VdcQueryAuthType.User), same Line 134: SignString(VdcQueryAuthType.User), Line 135: Line 136: // VM Template based entities queries Line 137: IsVmTemlateWithSameNameExist(VdcQueryAuthType.User), -- To view, visit https://gerrit.ovirt.org/38986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0cc2a2fd462bd8dc9085b300ec12fe46ff4518 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
