Omer Frenkel has posted comments on this change. Change subject: core:(2) Editing of template version for pools ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/36508/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java: Line 60: } Line 61: Line 62: @Override Line 63: protected void executeCommand() { Line 64: applyNextRunConfiguration(); now it might call the updateVmVersion, maybe we dont need to call detach users? or there might be a race that the vm will not exist? Line 65: Line 66: boolean removedStatelessSnapshot = detachUsers(); Line 67: if (!removedStatelessSnapshot) { Line 68: // If we are dealing with a prestarted Vm or a regular Vm - clean stateless images -- To view, visit https://gerrit.ovirt.org/36508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2249cfea12ffbab008c162d52928df782f5f9d85 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldan Shachar <eshac...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
