Daniel Erez has posted comments on this change. Change subject: core: introduce add Cinder disk support ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39024/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddCinderDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddCinderDiskCommand.java: Line 133: public CommandCallback getCallback() { Line 134: return new AddCinderDiskCommandCallback(); Line 135: } Line 136: Line 137: @Override > I would add a comment here just to avoid confusion that the disk should be Done Line 138: protected Map<String, Pair<String, String>> getExclusiveLocks() { Line 139: return Collections.emptyMap(); Line 140: } Line 141: -- To view, visit https://gerrit.ovirt.org/39024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie20f31afc59801e951b52053ba8bfef55e13e323 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
