Martin Peřina has posted comments on this change. Change subject: core: Replace FenceExecutor in InitVdsOnUpCommand ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38969/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java: Line 188: fence > I'm glad about the refactoring of FenceExcutor; I think the way you divided HostFenceActionExecutor contains two methods: 1. fence(FenceActionType) - it uses all fence agents defined for the host 2. fence(FenceActionType, FenceAgent) - it uses only fence agent specified as parameter IMO both methods have clear comments to distinguish between results of their execution. -- To view, visit https://gerrit.ovirt.org/38969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8939f51e8f42f1dc065e74e78b6e9be7011f8082 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
