Daniel Erez has posted comments on this change. Change subject: core: add disk_storage_type to base_disks table ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/39010/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java: Line 197: /** Line 198: * @return The type of underlying storage implementation. Line 199: */ Line 200: public DiskStorageType getDiskStorageType() { Line 201: return null; > Why do we return null? since the implementation is in the sub-clasees (DiskImageBase/LunDisk/etc) Line 202: } Line 203: Line 204: @Override Line 205: public int hashCode() { -- To view, visit https://gerrit.ovirt.org/39010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib910f991d060a8b8b0372c4b252501562fc5757a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
