Omer Frenkel has posted comments on this change. Change subject: core: update osinfo default values and remove clutter ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/39077/1/packaging/conf/osinfo-defaults.properties File packaging/conf/osinfo-defaults.properties: Line 171: os.windows_2003.sysprepPath.value = ${ENGINE_USR}/conf/sysprep/sysprep.2k3 Line 172: os.windows_2003.productKey.value = Line 173: os.windows_2003.isTimezoneTypeInteger.value = true Line 174: os.windows_2003.devices.audio.value = ac97 Line 175: os.windows_2003.devices.diskInterfaces.value = IDE, VirtIO_SCSI, VirtIO older versions were only ide,virtio, no? Line 176: Line 177: Line 178: # Windows2008(4, OsType.Windows, false), Line 179: os.windows_2008.id.value = 4 Line 202: os.windows_7.sysprepPath.value = ${ENGINE_USR}/conf/sysprep/sysprep.w7 Line 203: os.windows_7.sysprepFileName.value = Unattend.xml Line 204: os.windows_7.productKey.value = Line 205: os.windows_7.devices.audio.value = ich6 Line 206: os.windows_7.devices.diskInterfaces.value = IDE, VirtIO_SCSI, VirtIO same here Line 207: os.windows_7.isTimezoneTypeInteger.value = false Line 208: Line 209: # Windows7x64(12, OsType.Windows, true), Line 210: os.windows_7x64.id.value = 12 Line 321: os.other_ppc64.devices.cdInterface.value = scsi Line 322: os.other_ppc64.devices.balloon.enabled.value = false Line 323: os.other_ppc64.devices.diskInterfaces.value = VirtIO, VirtIO_SCSI, SPAPR_VSCSI Line 324: os.other_ppc64.devices.disk.hotpluggableInterfaces.value = VirtIO, VirtIO_SCSI, SPAPR_VSCSI Line 325: os.other_ppc64.devices.network.hotplugSupport.value = true what about old versions? (< 3.3) Line 326: os.other_ppc64.devices.display.protocols.value = vnc/vga Line 327: os.other_ppc64.devices.watchdog.models.value = i6300esb Line 328: # In the ppc64 architecture there are only three devices occupying Line 329: # virtual PCI slots in a newly created VM, the USB controller, -- To view, visit https://gerrit.ovirt.org/39077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94ab8349e3c5d8908e7b623d125519b3f38d3976 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
