Moti Asayag has posted comments on this change. Change subject: engine: introducing vfsConfigNetworks and vfsConfigLabels tables ......................................................................
Patch Set 13: Code-Review+2 (3 comments) https://gerrit.ovirt.org/#/c/36100/13/packaging/dbscripts/network_sp.sql File packaging/dbscripts/network_sp.sql: Line 1467: -- vfsConfigNetworks Line 1468: ---------------------------------------------------------------------- Line 1469: Line 1470: Create or replace FUNCTION InsertVfsConfigNetwork(v_vfs_config_id UUID, Line 1471: v_network_id UUID) please replace tabs with spaces. Line 1472: RETURNS VOID Line 1473: AS $procedure$ Line 1474: BEGIN Line 1475: INSERT INTO vfs_config_networks(vfs_config_id, network_id) Line 1472: RETURNS VOID Line 1473: AS $procedure$ Line 1474: BEGIN Line 1475: INSERT INTO vfs_config_networks(vfs_config_id, network_id) Line 1476: VALUES(v_vfs_config_id, v_network_id); here as well Line 1477: END; $procedure$ Line 1478: LANGUAGE plpgsql; Line 1479: Line 1480: Create or replace FUNCTION DeleteVfsConfigNetwork(v_vfs_config_id UUID, Line 1477: END; $procedure$ Line 1478: LANGUAGE plpgsql; Line 1479: Line 1480: Create or replace FUNCTION DeleteVfsConfigNetwork(v_vfs_config_id UUID, Line 1481: v_network_id UUID) and here. Line 1482: RETURNS VOID Line 1483: AS $procedure$ Line 1484: BEGIN Line 1485: DELETE FROM vfs_config_networks -- To view, visit https://gerrit.ovirt.org/36100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia383df7060b97c17459ef4576d300e7de217e966 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
