Maor Lipchuk has posted comments on this change. Change subject: core: add CinderDisksValidator ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39022/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java: Line 48: diskProxyMap.put(cinderDisk.getId(), volumeProviderProxy); Line 49: } Line 50: Line 51: } Line 52: return diskProxyMap; There is no reason to return here diskProxyMap, no one is using it and it is private Please change the method return type to void and change its name to "initializeDiskProxyMap" I would also pass the cinderDisks as a parameter, but that is only a suggestion Line 53: } Line 54: Line 55: private OpenStackVolumeProviderProxy getVolumeProviderProxy(CinderDisk cinderDisk) { Line 56: if (cinderDisk == null || cinderDisk.getStorageIds().isEmpty()) { -- To view, visit https://gerrit.ovirt.org/39022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I763c0467bb144a450ba68de2128cb7cea13ee983 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
