Piotr Kliczewski has posted comments on this change. Change subject: gluster: add 'gluster' prefix to getStorageDeviceList method ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38508/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java: Line 379: Map<String, Object> raidParams, Line 380: String fsType, Line 381: String[] storageDevices); Line 382: Line 383: StorageDeviceListReturnForXmlRpc getGlusterStorageDeviceList(); Naming convention is to use gluster<method_name> so please follow it. -- To view, visit https://gerrit.ovirt.org/38508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia053fd11c2c8b8ef3faddcfb1660c55a1cbf56bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
