Maor Lipchuk has posted comments on this change. Change subject: core: adding CinderDiskRowMapper ......................................................................
Patch Set 4: -Code-Review (1 comment) removing the +2 until findbugs will be fixed https://gerrit.ovirt.org/#/c/39014/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java: Line 272: } Line 273: Line 274: protected static class CinderDiskRowMapper extends AbstractDiskRowMapper<CinderDisk> { Line 275: Line 276: public static CinderDiskRowMapper instance = new CinderDiskRowMapper(); should be final or maybe better to use simply getter such as getInstance() Line 277: Line 278: private CinderDiskRowMapper() { Line 279: } Line 280: -- To view, visit https://gerrit.ovirt.org/39014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I755f75f32bcada9e6c446c86b1d7109fb94768ad Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
