Maor Lipchuk has posted comments on this change. Change subject: core: add cinder_volume_type to base_disks table ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39011/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage/BaseDisk.java: Line 211: return null; Line 212: } Line 213: Line 214: @Override Line 215: public int hashCode() { should be also part of the hashcode && equals? Line 216: final int prime = 31; Line 217: int result = 1; Line 218: result = prime * result + ((id == null) ? 0 : id.hashCode()); Line 219: result = prime * result + ((diskAlias == null) ? 0 : diskAlias.hashCode()); -- To view, visit https://gerrit.ovirt.org/39011 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2be3d75e50ae72062d6222ad917b578176a6590 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
