Vered Volansky has posted comments on this change.

Change subject: core: Add storage space thresholds support
......................................................................


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/35277/14/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java:

Line 103:                     if (storage.isSetMountOptions()) {
Line 104:                         
entity.setMountOptions(storage.getMountOptions());
Line 105:                     }
Line 106:                     if(storage.getNfsTimeo() != null) {
Line 107:                         
entity.setNfsTimeo(storage.getNfsTimeo().shortValue());
Shouldn't be here, will be removed
Line 108:                     }
Line 109:                     break;
Line 110:                 case LOCALFS:
Line 111:                     if (storage.isSetPath()) {


-- 
To view, visit https://gerrit.ovirt.org/35277
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19621dfc770c69003d731a7593d037d7d4040a82
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Idan Shaby <ish...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to