Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: Use constants for db env keys ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/39061/1/packaging/setup/ovirt_engine_setup/engine/constants.py File packaging/setup/ovirt_engine_setup/engine/constants.py: Line 28: from ovirt_engine_setup.constants import classproperty Line 29: from ovirt_engine_setup.constants import osetupattrs Line 30: from ovirt_engine_setup.constants import osetupattrsclass Line 31: from ovirt_engine_setup.engine_common import constants as oengcommcons Line 32: dek = oengcommcons.DBEnvKeysConst from oengcommcons import DBEnvKeysConst as DEK please use uppercase to make clear it's not a module but a class / constant Line 33: Line 34: from . import config Line 35: Line 36: https://gerrit.ovirt.org/#/c/39061/1/packaging/setup/ovirt_engine_setup/engine_common/database.py File packaging/setup/ovirt_engine_setup/engine_common/database.py: Line 30: Line 31: from ovirt_engine_setup import util as osetuputil Line 32: from ovirt_engine_setup import dialog Line 33: from ovirt_engine_setup.engine_common import constants as oengcommcons Line 34: dek = oengcommcons.DBEnvKeysConst same here Line 35: Line 36: Line 37: def _(m): Line 38: return gettext.dgettext(message=m, domain='ovirt-engine-setup') https://gerrit.ovirt.org/#/c/39061/1/packaging/setup/ovirt_engine_setup/engine_common/postgres.py File packaging/setup/ovirt_engine_setup/engine_common/postgres.py: Line 29: Line 30: from ovirt_engine_setup import constants as osetupcons Line 31: from ovirt_engine_setup import util as osetuputil Line 32: from ovirt_engine_setup.engine_common import constants as oengcommcons Line 33: dek = oengcommcons.DBEnvKeysConst and here Line 34: from ovirt_engine_setup.engine_common import database Line 35: Line 36: Line 37: def _(m): -- To view, visit https://gerrit.ovirt.org/39061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I271b1c7c3682a3d0bcc69ae6ea6c9e717ed029d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
