Alexander Wels has posted comments on this change. Change subject: userportal,webadmin: multiple login messages ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38214/2/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java: Line 195: Label messageLabel = new Label(); Line 196: messageLabel.setHTML(message.asString()); Line 197: messageLabel.addStyleName(style.loginMessageError()); Line 198: errorMessagePanel.add(messageLabel); Line 199: errorMessagePanel.setVisible(true); > But in case there are no messages, shouldn't we call setVisible(false) - fo clearErrorMessages() sets the visibility to false. Line 200: } Line 201: } Line 202: Line 203: public void resetAndFocus() { -- To view, visit https://gerrit.ovirt.org/38214 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd3bc6b716797583d3fc69fc69746bc3362eb58d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
