Tomas Jelinek has posted comments on this change. Change subject: webadmin: expose permissions creation date ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38400/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java: Line 68: Line 69: AbstractTextColumnWithTooltip<Permissions> creationDateColumn = new AbstractTextColumnWithTooltip<Permissions>() { Line 70: @Override Line 71: public String getValue(Permissions object) { Line 72: return new Date(object.getCreationDate() * 1000).toString(); // GWT doesn't have TimeUnit.java > should be in the form of: in that case I would recommend to use the FullDateTimeRenderer since that one is used across the app to render date so it will be both consistent with the rest of the app and also locale aware. It is used like this: AbstractTextColumnWithTooltip<Permissions> creationDateColumn = new AbstractRenderedTextColumn<Permissions, Date>(new FullDateTimeRenderer()) { @Override protected Date getRawValue(Permissions object) { return new Date(object.getCreationDate() * 1000).toString(); // GWT doesn't have TimeUnit.java } }; Line 73: } Line 74: }; Line 75: getTable().addColumn(creationDateColumn, constants.permissionsCreationDate(), "300px"); //$NON-NLS-1$ Line 76: creationDateColumn.makeSortable(); -- To view, visit https://gerrit.ovirt.org/38400 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c226ed01761ae3836940b5be6f2f2bd82a6f092 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
