Omer Frenkel has posted comments on this change. Change subject: core: on init - clear down vms after vms monitoring ......................................................................
Patch Set 2: ok so new approach in this patch: no complicated logic for a single place to be called when both host and vms monitoring finish init (first monitoring cycle) instead, just calling the method on resource manager (now callled handleVmsFinishedInitOnVds) when vms monitoring finish first cycle successfully. pro - cleaner simpler code cons - now this method is called in different place and time, its a little hard to verify all cases are covered, so please, while reviewing, try to attach any scenario on your mind. so far tested: * "regular" scenario where engine starts, one host up with vm, another up without, and another in maintenance. * engine starts where host that runs vm does not have communication - works ok, the method is called only when the connection was restored, as expected -- To view, visit https://gerrit.ovirt.org/38850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I109dcbe221526c2503f26307cef93aac8a94d689 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
