Vojtech Szocs has posted comments on this change. Change subject: webadmin: cluster guide me datacenter ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/37763/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java: Line 238: model.updateOptionsLocalFSData(); Line 239: } Line 240: } Line 241: }), getEntity().getStoragePoolId()); Line 242: } else if (getEntity().getStoragePoolId() == null) { The condition in this "else" clause could be left out (complements the non-null "if" clause above), I leave it up to you. Line 243: //No data-center associated with this cluster. Line 244: AsyncDataProvider.getInstance().getDataCenterList(new AsyncQuery(this, new INewAsyncCallback() { Line 245: @Override Line 246: public void onSuccess(Object target, Object returnValue) { https://gerrit.ovirt.org/#/c/37763/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/AddDataCenterClusterPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/AddDataCenterClusterPopupView.java: Line 29: } Line 30: private static final ApplicationConstants constants = AssetProvider.getConstants(); Line 31: Line 32: @UiField(provided = true) Line 33: EntityModelCellTable<ListModel<EntityModel<StoragePool>>> dataCentersTable; Can this be private? Line 34: Line 35: @Inject Line 36: public AddDataCenterClusterPopupView(EventBus eventBus) { Line 37: super(eventBus); -- To view, visit https://gerrit.ovirt.org/37763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifaafdd5593d3721b9e6a8b466b2ac186b18bd6fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
