Eliraz Levi has posted comments on this change.

Change subject: webadmin: adding network-out-of-sync to SubTabNetworkHost
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38291/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java:

Line 129: 
Line 130:         row.setWidget(0, 1, networkName);
Line 131: 
Line 132:         // Network sync status
Line 133:         VdsNetworkInterface iface = lineModel.getIsBonded()? 
lineModel.getInterface() : lineModel.getInterfaces().get(0).getInterface();
> This isn't formatted. As usual.
Done
Line 134:         VdsNetworkInterface.NetworkImplementationDetails 
ifaceNetworkImpDetails =  (iface != null) ? 
iface.getNetworkImplementationDetails() : null;
Line 135:         boolean isSYnc = (ifaceNetworkImpDetails != null) ? 
ifaceNetworkImpDetails.isInSync() : true;
Line 136: 
Line 137:         row.setWidget(0, 2, getSyncPanel(isSYnc));


-- 
To view, visit https://gerrit.ovirt.org/38291
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id200f9c135f1097572feac300e255a438cfb295a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eliraz Levi <el...@redhat.com>
Gerrit-Reviewer: Eliraz Levi <el...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to