Eli Mesika has posted comments on this change. Change subject: core: FenceVdsVDSCommandParameters code cleanup ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/38061/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java: Line 172: protected String getVdsFenceOptions(String type, String options, String compatibilityVersion) { Line 173: return new VdsFenceOptions(type, options, compatibilityVersion).ToInternalString(); Line 174: } Line 175: Line 176: protected FenceStatusReturnForXmlRpc fenceNode(FenceActionType actionType, boolean applyFencingPolicy) { maybe it worth FenceAgent agent = getParameters().getFenceAgent(); and then using agent instead Line 177: return getBroker().fenceNode( Line 178: getParameters().getFenceAgent().getIp(), Line 179: getParameters().getFenceAgent().getPort() == null Line 180: ? "" -- To view, visit https://gerrit.ovirt.org/38061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I055276a4012180fda23bb2063c38df3bdd6ce876 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
