Juan Hernandez has posted comments on this change. Change subject: restapi: added auth_url element to external provider ......................................................................
Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/38949/1/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 5088: <xs:element name="url" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 5089: <xs:element name="requires_authentication" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 5090: <xs:element name="username" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 5091: <xs:element name="password" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 5092: <xs:element name="auth_url" type="xs:string" minOccurs="0" maxOccurs="1"/> Can you rename to "authentication_url", just to be consistent with "requires_authentication"? Line 5093: <xs:element ref="properties" minOccurs="0" maxOccurs="1"/> Line 5094: </xs:sequence> Line 5095: </xs:extension> Line 5096: </xs:complexContent> -- To view, visit https://gerrit.ovirt.org/38949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05125d426bb22949237fcc5b57293d835b6d34c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
