Eli Mesika has posted comments on this change. Change subject: engine: CRUD actions for HostNicVfsConfig ......................................................................
Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/35948/14/packaging/dbscripts/upgrade/03_06_1060_add_host_nic_vfs_config_table.sql File packaging/dbscripts/upgrade/03_06_1060_add_host_nic_vfs_config_table.sql: Line 8: CREATE TABLE host_nic_vfs_config Line 9: ( Line 10: id UUID NOT NULL, Line 11: nic_id UUID NOT NULL, Line 12: all_networks_allowed BOOLEAN NOT NULL, > it doesn't seem to be any constant convention for it. we are trying to do things right from now on, I have no control on past commits that were merged without my +1 but now I am looking on each commit that is DB related even if I am not in the review list , so the fact that we have mixed names is correct but it should not prevent us from going in a more clear and standard way ... Line 13: _create_date TIMESTAMP WITH TIME ZONE default LOCALTIMESTAMP, Line 14: _update_date TIMESTAMP WITH TIME ZONE default NULL Line 15: ); Line 16: -- To view, visit https://gerrit.ovirt.org/35948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I022a1d19d935832a8baae41c123322dff0ab779b Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
