Allon Mureinik has posted comments on this change. Change subject: core: Remove constant SIZE_IS_NOT_AVAILABLE ......................................................................
Patch Set 2: Code-Review-1 (2 comments) Patch doesn't compile. Also, see inline. https://gerrit.ovirt.org/#/c/39004/2/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java: Line 210: assertSame(true, Line 211: listOfRepoFiles.get(0).getLastRefreshed() == newRepoFileMap Line 212: .getLastRefreshed()); Line 213: assertSame(true, Line 214: listOfRepoFiles.get(0).getSize().equals(newRepoFileMap.getSize())); Just use assertEquals Line 215: assertSame( Line 216: true, Line 217: listOfRepoFiles.get(0).getRepoDomainId() Line 218: .equals(newRepoFileMap.getRepoDomainId())); https://gerrit.ovirt.org/#/c/39004/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/FileStatsReturnForXmlRpc.java: Line 54: } Line 55: Line 56: private void createDefaultFileStats(Object[] fileNames) { Line 57: Map<String, Object> defaultFileStats = new HashMap<>(); Line 58: defaultFileStats.put(VdsProperties.size, null); IIUC, this is redundant - if you don't have a default, you'll get null anyway. So perhaps this entire method can be removed? Line 59: Line 60: for (int i = 0; i < fileNames.length; i++) { Line 61: fileStats.put((String) fileNames[i], defaultFileStats); Line 62: } -- To view, visit https://gerrit.ovirt.org/39004 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida18353f1d5c976ee70e65045b80410dded2bb1f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
