Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: queue name configuration ......................................................................
Patch Set 6: (4 comments) https://gerrit.ovirt.org/#/c/36364/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 393: @DefaultValueAttribute("TLSv1") Line 394: ExternalCommunicationProtocol, Line 395: @TypeConverterAttribute(String.class) Line 396: @DefaultValueAttribute("jms.queue.requests") Line 397: VdsRequestQueueName, > 'vds' prefix should be replaced by 'host' vds is here to keep consistency. Most of communication configuration is prefixed with vds. Line 398: @TypeConverterAttribute(String.class) Line 399: @DefaultValueAttribute("jms.queue.reponses") Line 400: VdsResponseQueueName, Line 401: @TypeConverterAttribute(String.class) https://gerrit.ovirt.org/#/c/36364/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java: Line 17: Line 18: public class JsonRpcUtils { Line 19: private static Logger log = LoggerFactory.getLogger(JsonRpcUtils.class); Line 20: Line 21: public static JsonRpcClient createStompClient(String hostname, int port, int connectionTimeout, > please use formatter Will format this class. Line 22: int clientTimeout, int connectionRetry, int heartbeat, boolean isSecure, String protocol, Line 23: String requestQueue, String responseQueue) { Line 24: ClientPolicy connectionPolicy = Line 25: new StompClientPolicy(connectionTimeout, connectionRetry, heartbeat, IOException.class, requestQueue, responseQueue); Line 26: ClientPolicy clientPolicy = new ClientPolicy(clientTimeout, connectionRetry, heartbeat, IOException.class); Line 27: return createClient(hostname, port, connectionPolicy, clientPolicy, isSecure, ReactorType.STOMP, protocol); Line 28: } Line 29: Line 30: public static JsonRpcClient createClient(String hostname, int port, int connectionTimeout, > please use formatter As above Line 31: int clientTimeout, int connectionRetry, int heartbeat, boolean isSecure, ReactorType type, String protocol) { Line 32: ClientPolicy connectionPolicy = Line 33: new ClientPolicy(connectionTimeout, connectionRetry, heartbeat, IOException.class); Line 34: ClientPolicy clientPolicy = new ClientPolicy(clientTimeout, connectionRetry, heartbeat, IOException.class); Line 54: throw new IllegalStateException(e); Line 55: } Line 56: } Line 57: Line 58: private static JsonRpcClient getJsonClient(Reactor reactor, String hostName, int port, ClientPolicy > same As above Line 59: connectionPolicy, ClientPolicy clientPolicy) throws ClientConnectionException { Line 60: final ReactorClient client = reactor.createClient(hostName, port); Line 61: client.setClientPolicy(connectionPolicy); Line 62: ResponseWorker worker = ReactorFactory.getWorker(); -- To view, visit https://gerrit.ovirt.org/36364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69e81ed28b568744d3cd8bb306f3942dbf4e08eb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
