Daniel Erez has uploaded a new change for review. Change subject: core: redundant sd looping in VolumeProviderProxy onRemoval ......................................................................
core: redundant sd looping in VolumeProviderProxy onRemoval Remove redundant storage domains looping from onRemoval method (in OpenStackVolumeProviderProxy) - since each provider is associated to a single storage domain. Change-Id: I28f6348fec6882d39876314659edeea299b4ee07 Bug-Url: https://bugzilla.redhat.com/1185826 Signed-off-by: Daniel Erez <de...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/21/39021/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java index 1959ad7..10b7801 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackVolumeProviderProxy.java @@ -70,9 +70,8 @@ List<StorageDomain> storageDomains = getDbFacade().getStorageDomainDao().getAllByConnectionId(provider.getId()); // Removing the static and dynamic storage domain entries - for (StorageDomain storageDomainEntry : storageDomains) { - getDbFacade().getStorageDomainDao().remove(storageDomainEntry.getId()); - } + StorageDomain storageDomainEntry = storageDomains.get(0); + getDbFacade().getStorageDomainDao().remove(storageDomainEntry.getId()); } public static OpenStackVolumeProviderProxy getFromStorageDomainId(Guid storageDomainId) { -- To view, visit https://gerrit.ovirt.org/39021 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28f6348fec6882d39876314659edeea299b4ee07 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
