Doron Fediuck has posted comments on this change.
Change subject: engine: Add notification to quota resize (#848289)
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
Ofri, please see inline for specific issues.
Also, please split UI changes to a different patch.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java
Line 106: &&
!getQuota().getGlobalQuotaStorage().getStorageSizeGB().equals(QuotaStorage.UNLIMITED)
Line 107: &&
getQuota().getGlobalQuotaStorage().getStorageSizeGB()
Line 108: <
getQuota().getGlobalQuotaStorage().getStorageSizeGBUsage()); // for global quota
Line 109: //for specific quota
Line 110: if (getQuota().getQuotaStorages() != null) {
This if should also check if newSizeUnderCurrentConsumption is not already true.
If it is true, no point of going into this condition, or your logic isn't right.
Line 111: for (QuotaStorage quotaStorage :
getQuota().getQuotaStorages()) {
Line 112: newSizeUnderCurrentConsumption |=
quotaStorage.getStorageSizeGB() < quotaStorage.getStorageSizeGBUsage();
Line 113: }
Line 114: }
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 110: USER_EXCEEDED_QUOTA_VDS_GROUP_THRESHOLD=Cluster-Quota ${QuotaName} is
about to exceed. Utilization: ${Utilization}
Line 111: USER_EXCEEDED_QUOTA_STORAGE_GRACE_LIMIT=Storage-Quota ${QuotaName}
limit exceeded and operation was blocked. Utilization(used/requested):
${CurrentStorage}%/${Requested}% - Please select a different quota or contact
your administrator to extend the the quota.
Line 112: USER_EXCEEDED_QUOTA_STORAGE_LIMIT=Storage-Quota ${QuotaName} limit
exceeded and entered the grace zone. Utilization: ${CurrentStorage}% (It is
advised to select a different quota or contact your administrator to extend the
the quota).
Line 113: USER_EXCEEDED_QUOTA_STORAGE_THRESHOLD=Storage-Quota ${QuotaName} is
about to exceed. Utilization: ${CurrentStorage}%
Line 114: QUOTA_STORAGE_RESIZE_LOWER_THEN_CONSUMPTION=Storage-Quota
${QuotaName}: new size is under the current utilization.
the new size set for this quota is less than existing utilization. Thus, this
quota already exceeds its limits. Consider reviewing the quota settings.
Line 115: USER_MOVED_VM=VM ${VmName} moving to Domain ${StorageDomainName} was
initiated by ${UserName}.
Line 116: USER_MOVED_VM_FINISHED_SUCCESS=Moving VM ${VmName} to Domain
${StorageDomainName} has been completed.
Line 117: USER_MOVED_VM_FINISHED_FAILURE=Failed to complete moving of VM
${VmName} to Domain ${StorageDomainName}.
Line 118: USER_FAILED_MOVE_VM=Failed to initiate moving of VM ${VmName} to
Domain ${StorageDomainName} (User: ${UserName}).
--
To view, visit http://gerrit.ovirt.org/7824
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ef7f831120cafa10aa55e51db0270915b221c9f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
