Ayal Baron has posted comments on this change. Change subject: core:Import VM should not be blocked when collapse. ......................................................................
Patch Set 6: I would prefer that you didn't submit this (1 inline comment) .................................................... Commit Message Line 7: core:Import VM should not be blocked when collapse. Line 8: Line 9: Import VM with disks to block-device domain will not be blocked for Line 10: images which have sparse volume type and RAW volume format, Line 11: if user sends copy collapse option as true. this is wrong. UI needs to send proper combination. If user chose copy-collapse then target format can change hence ui can pass something different than the source. If UI still chooses to pass sparse raw with copy collapse you still need to fail. In other words, correct flow should be: 1. if user chose *not* to collapse then target allocation policy and target format = source parameters. 2. if user chose to collapse then target allocation policy and target format = whatever was passed as parameters from UI (if nothing then = source parameters) Then just validate that allocation policy and format are supported on target storage domain. Line 12: Line 13: Block-Device does not support RAW sparse volumes, so disk with snapshot Line 14: can not be imported to ISCSI domain. Line 15: If user will choose to copy collapse the image then the volume will -- To view, visit http://gerrit.ovirt.org/7756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6f4b762fbd9770c5157fee6b24373fa9a0dca10 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
