Eli Mesika has uploaded a new change for review.
Change subject: core: Report event on time drift ...(#848862)
......................................................................
core: Report event on time drift ...(#848862)
Report event on time drift between engine and vdsm(#848862)
This patch series adds time drift check per host.
New configuration values were added
EnableHostTimeDrift - indicates if time-drift check is ON (default
false)
HostTimeDriftInSec - Max allowed time drift in seconds (default 300)
Each time that getVdsStsats is executed by the engine, it gets the host
date in GMT and compare it with local engine date, if the difference in
seconds exceeded HostTimeDriftInSec and EnableHostTimeDrift is ON, an
ALERT is written to the log.
The new configuration values are available for editing in engine-config
and the new event named VDS_TIME_DRIFT_ALERT can be managed to get
notifications on that event.
To prevent event-flood, this event is issued once an hour per Host.
Change-Id: I9544418dc49f8e9e75f6c8c7f091c96726b1f30d
Signed-off-by: Eli Mesika <emes...@redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
2 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/7826/1
diff --git a/backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
b/backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
index b0a8a14..47fabdb 100644
--- a/backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
+++ b/backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
@@ -104,6 +104,8 @@
select fn_db_add_config_value('EmulatedMachine','rhel6.0.0','3.0');
select fn_db_add_config_value('EmulatedMachine','pc-0.14','3.1');
select fn_db_add_config_value('EmulatedMachine','pc-0.14','3.2');
+-- Host time drift
+select fn_db_add_config_value('EnableHostTimeDrift','false','general');
--Handling Enable Spice Root Certification Validation
select
fn_db_add_config_value('EnableSpiceRootCertificateValidation','true','general');
select fn_db_add_config_value('EnableSwapCheck','true','general');
@@ -137,6 +139,7 @@
select
fn_db_add_config_value('GuestToolsSetupIsoPrefix','RHEV-toolsSetup_','general');
select
fn_db_add_config_value('HighUtilizationForEvenlyDistribute','75','general');
select fn_db_add_config_value('HighUtilizationForPowerSave','75','general');
+select fn_db_add_config_value('HostTimeDriftInSec','300','general');
select fn_db_add_config_value('HotPlugEnabled','false','2.2');
select fn_db_add_config_value('HotPlugEnabled','false','3.0');
select fn_db_add_config_value('HotPlugEnabled','true','3.1');
diff --git
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
index 2059b36..da7b3fd 100644
---
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
+++
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
@@ -1463,6 +1463,17 @@
@DefaultValueAttribute("true")
EnableMACAntiSpoofingFilterRules(381),
+ // Host time drift
+ @Reloadable
+ @TypeConverterAttribute(Boolean.class)
+ @DefaultValueAttribute("false")
+ EnableHostTimeDrift(382),
+
+ @Reloadable
+ @TypeConverterAttribute(Integer.class)
+ @DefaultValueAttribute("300")
+ HostTimeDriftInSec(383),
+
Invalid(65535);
private int intValue;
--
To view, visit http://gerrit.ovirt.org/7826
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9544418dc49f8e9e75f6c8c7f091c96726b1f30d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
