Roy Golan has posted comments on this change. Change subject: engine: Externalized default value in policy ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38875/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityWeightPolicyUnit.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityWeightPolicyUnit.java: Line 14: import org.ovirt.engine.core.compat.Guid; Line 15: Line 16: public class VmAffinityWeightPolicyUnit extends PolicyUnitImpl { Line 17: Line 18: public static final int DEFAULT_SCORE = 1; I guess its not the only place to use a default score(even tough we possible not using anywhere else except here). please find a more general place. Line 19: Line 20: public VmAffinityWeightPolicyUnit(PolicyUnit policyUnit) { Line 21: super(policyUnit); Line 22: } -- To view, visit https://gerrit.ovirt.org/38875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I244ac0cd9cb41833c7a5357264ddca99e489de94 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
