Moti Asayag has posted comments on this change. Change subject: engine: RefreshHostDevicesCommand should't proceed in case of vdsm failure ......................................................................
Patch Set 2: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/38886/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdev/RefreshHostDevicesCommand.java: Line 40: @Override Line 41: protected void executeCommand() { Line 42: VDSReturnValue vdsReturnValue = resourceManager.runVdsCommand(VDSCommandType.HostDevListByCaps, new VdsIdAndVdsVDSCommandParametersBase(getVds())); Line 43: Line 44: if (!vdsReturnValue.getSucceeded()) { no need to report the failure reason ? is this an internal action only ? Line 45: return; Line 46: } Line 47: Line 48: List<HostDevice> fetchedDevices = (List<HostDevice>) vdsReturnValue.getReturnValue(); -- To view, visit https://gerrit.ovirt.org/38886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec8a4549bd76bce766ea9f7e6dde17b86f7e0a67 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
